Jonas Ådahl [Mon, 15 Jul 2019 13:47:12 +0000 (15:47 +0200)]
gdk: Remove gdk_surface_move_resize() API
Windows/surface's aren't supposed to be explicitly moved by any external
part, so don't provide API for doing so. Usage throughout Gdk is
replaced by the corresponding backend variants.
Jonas Ådahl [Mon, 15 Jul 2019 09:35:24 +0000 (11:35 +0200)]
gdk: Make backends implement move_to_rect()
The generic layer still does the heavy lifting, leaving the backends
more or less just act as thin wrappers, dealing a bit with global
coordinate transformations. The end goal is to remove explicit surface
moving from the generic gdk layer.
Jonas Ådahl [Mon, 15 Jul 2019 09:32:35 +0000 (11:32 +0200)]
gdk: Remove gdk_surface_move()
Generic gdk code now uses the internal helper; backends use their own
private implementations when necessary.
Jonas Ådahl [Mon, 15 Jul 2019 08:54:44 +0000 (10:54 +0200)]
gdk/surface: Add toplevel_resize vfunc
To separate how toplevels and popups are configured, a first step is to
introduce a resize-only vfunc for backends to implement. It's meant to
only configure toplevel windows, i.e. popups. Currently it's used for
both types, but introducing the resize-only API is a first step.
Jonas Ådahl [Fri, 12 Jul 2019 13:54:32 +0000 (15:54 +0200)]
wayland: Cleanup surface configuration
Configuration should happen in response to the xdg_surface.configure
event, not in the events that preceeds it. Do this by making all
configured state pending until the committing "configure" event. Also
split up toplevel vs popup configuration in a more clear way.
Jonas Ådahl [Fri, 12 Jul 2019 13:24:18 +0000 (15:24 +0200)]
wayland: Rename gdk_wayland_surface_configure to *_resize
It only issues a resize; configuring should imply more state is
configured, e.g. maximized, etc.
Jonas Ådahl [Fri, 5 Jul 2019 17:44:28 +0000 (19:44 +0200)]
tests: Remove obsolete props from popover2.ui
Matthias Clasen [Wed, 24 Jul 2019 13:51:22 +0000 (13:51 +0000)]
Merge branch 'gtkapp-opening-str' into 'master'
Use commas to differentiate between text and filename
See merge request GNOME/gtk!1013
Jordi Mas [Wed, 24 Jul 2019 13:51:22 +0000 (13:51 +0000)]
Use commas to differentiate between text and filename
Matthias Clasen [Wed, 24 Jul 2019 13:50:04 +0000 (13:50 +0000)]
Merge branch 'missing-gobject-annotation' into 'master'
Add nullable annotation to combo_box_text_get_active_text
See merge request GNOME/gtk!1012
Timm Bäder [Wed, 24 Jul 2019 06:10:37 +0000 (08:10 +0200)]
passwordentry: Normalize boolean value
Timm Bäder [Wed, 24 Jul 2019 06:10:26 +0000 (08:10 +0200)]
passwordentry: Remove empty vfunc implementation
Timm Bäder [Mon, 22 Jul 2019 11:59:47 +0000 (13:59 +0200)]
textlayout: Avoid querying CSS state if we don't have to
This is actually pretty slow, and we almost never render a selection.
Timm Bäder [Sun, 21 Jul 2019 13:38:13 +0000 (15:38 +0200)]
popover: Remove some unnecessary checks
gtk_popover_move_resize() already checks whether the popover has a
surface.
Matthias Clasen [Wed, 24 Jul 2019 03:26:58 +0000 (23:26 -0400)]
Remove a redundant vfunc
PangoRenderer has a perfectly adequate default
implementation of draw_glyphs, no need to duplicate that.
Ryan Westlund [Wed, 24 Jul 2019 02:09:06 +0000 (22:09 -0400)]
Add nullable annotation to combo_box_text_get_active_text
Matthias Clasen [Wed, 24 Jul 2019 02:05:32 +0000 (02:05 +0000)]
Merge branch 'blink-later' into 'master'
Blink later
See merge request GNOME/gtk!1011
Matthias Clasen [Wed, 24 Jul 2019 01:39:37 +0000 (01:39 +0000)]
Merge branch 'error-nodes' into 'master'
Render error underlines as render nodes
See merge request GNOME/gtk!1009
Matthias Clasen [Wed, 24 Jul 2019 01:18:03 +0000 (21:18 -0400)]
textview: Defer cursor blinking on input
We were not calling the right cursor functions
in the commit handler.
Matthias Clasen [Wed, 24 Jul 2019 01:17:05 +0000 (21:17 -0400)]
textview: Delay initial cursor blinking
These changes follow the same changes for
gtktext.c in the previous commit.
Matthias Clasen [Wed, 24 Jul 2019 01:08:47 +0000 (21:08 -0400)]
text: Delay initial cursor blinking
We used to have a solid cursor for 2/3 of the cycle,
now we start fading after 1/4th. To make up for it,
add half a cycle of delay.
Matthias Clasen [Tue, 23 Jul 2019 22:44:59 +0000 (22:44 +0000)]
Merge branch 'wip/chergert/refcount-line-display' into 'master'
make GtkTextLineDisplay ref counted
See merge request GNOME/gtk!1010
Matthias Clasen [Tue, 23 Jul 2019 21:21:16 +0000 (17:21 -0400)]
Render error underlines as render nodes
Use a sequence of transformed squares,
instead of a cairo node. The drawing is not
identical to the previous code, but reasonably
close.
Christian Hergert [Tue, 23 Jul 2019 21:59:40 +0000 (14:59 -0700)]
textlayout: remove use of gtk_text_layout_free_line_display
Now that these are reference counted, we no longer need to use
the variant requiring access to the GtkTextLayout.
Christian Hergert [Tue, 23 Jul 2019 21:52:14 +0000 (14:52 -0700)]
textlayout: make GtkTextLineDisplay reference counted
This makes GtkTextLineDisplay use GRcBox instead of g_slice_*
directly. By using reference counting for this structure, we
can ensure that we hold an extra ref for one_display_cache as
well as caching additional GtkTextLineDisplay for the visible
range in the future.
Matthias Clasen [Tue, 23 Jul 2019 19:14:38 +0000 (15:14 -0400)]
text: Remove an outdated comment
Matthias Clasen [Tue, 23 Jul 2019 18:26:32 +0000 (14:26 -0400)]
fix the build
Piotr Drąg [Tue, 23 Jul 2019 17:47:43 +0000 (19:47 +0200)]
Update POTFILES.in
Matthias Clasen [Tue, 23 Jul 2019 01:01:22 +0000 (18:01 -0700)]
text: Fix incomplete invalidation
When a style change affects the text, we need to
clear the cached content, in order to pick up the
new text style.
Matthias Clasen [Tue, 23 Jul 2019 00:42:25 +0000 (17:42 -0700)]
text view: Fix incomplete invalidation
Update the cached text style when a css change affects
content or background. This fixes text views drawing
black-on-dark when switching to the dark theme.
Jordi Mas [Mon, 22 Jul 2019 09:06:27 +0000 (11:06 +0200)]
Update Catalan translation
Matthias Clasen [Mon, 22 Jul 2019 01:53:17 +0000 (01:53 +0000)]
Merge branch 'wip/chergert/fix-textlayout-bounds' into 'master'
textlayout: fix bounds for clipping
See merge request GNOME/gtk!1006
Christian Hergert [Mon, 22 Jul 2019 01:21:04 +0000 (18:21 -0700)]
textlayout: fix bounds for clipping
This should match gtk_snapshot_append_layout(), which means that we expect the
bounds to be rooted at 0, 0.
Matthias Clasen [Sun, 21 Jul 2019 23:10:41 +0000 (23:10 +0000)]
Merge branch 'wip/textview' into 'master'
textview: port GtkTextView to GskPangoRenderer
See merge request GNOME/gtk!1005
Matthias Clasen [Sun, 21 Jul 2019 20:06:23 +0000 (13:06 -0700)]
text view: Smooth cursor blinking
Fade the text cursor in and out, instead
of abruptly turning it on and off.
Christian Hergert [Sun, 21 Jul 2019 01:25:51 +0000 (18:25 -0700)]
textview: port GtkTextView to GskPangoRenderer
This removes the use of GtkTextDisplay (a PangoRenderer) to use
the GskPangoRender which generates render nodes. Part of this means
improving the GskPangoRenderer to support the necessary features for
displaying a GtkTextView.
Primarily, this is a merging of GtkTextDisplay features into
GskPangoRender. Additionally, GtkTextDisplay was removed to allow for
gtk_text_layout_snapshot() to be implemented elsewhere.
Matthias Clasen [Sun, 21 Jul 2019 18:49:13 +0000 (11:49 -0700)]
textview: Stop exporting private apis
These headers are no longer 'semi-public, but private
and uninstalled, so exporting these functions does
not do any good.
Matthias Clasen [Sun, 21 Jul 2019 20:18:58 +0000 (13:18 -0700)]
gsk: Fix a crash in gsk_render_node_diff
The only thing worse than freeing the same
cairo region twice is freeing it three times.
Matthias Clasen [Sun, 21 Jul 2019 01:12:05 +0000 (18:12 -0700)]
text: Smooth cursor blinking
Fade the text cursor in and out, instead
of abruptly turning it on and off.
Matthias Clasen [Sun, 21 Jul 2019 16:50:41 +0000 (09:50 -0700)]
Adwaita: Fix entry block cursors
Asier Sarasua Garmendia [Sun, 21 Jul 2019 18:02:07 +0000 (18:02 +0000)]
Update Basque translation
Serdar Sağlam [Sun, 21 Jul 2019 14:15:15 +0000 (14:15 +0000)]
Update Turkish translation
Timm Bäder [Sun, 21 Jul 2019 09:08:45 +0000 (11:08 +0200)]
window: Plug a GList leak
We need to free the GList manually when using g_list_remove_link().
Timm Bäder [Sun, 21 Jul 2019 10:23:56 +0000 (12:23 +0200)]
gtk.supp: Add glXQueryServerString exceptions
Timm Bäder [Sun, 21 Jul 2019 10:11:36 +0000 (12:11 +0200)]
gl renderer: Remove leftover modelview matrix
We use a GskTransform there nowadays.
Timm Bäder [Sun, 21 Jul 2019 10:43:00 +0000 (12:43 +0200)]
Revert "gl renderer: ops_set_modelview is (transfer full)"
This reverts commit
e904c49e8aaebc266bac9024b13389e4521bbbaa.
This breaks HiDPI setups, i.e. setups where the call to
ops_set_modelview does not end up with a NULL transform.
Timm Bäder [Sun, 21 Jul 2019 08:52:12 +0000 (10:52 +0200)]
window: Merge some functions into their only callers
So it's clear we only add or remove the pointerfocus-es in
_update_pointer_focus.
Timm Bäder [Sun, 21 Jul 2019 08:26:00 +0000 (10:26 +0200)]
cellrenderertext: Remove some unnecessary NULL checks
Timm Bäder [Sun, 21 Jul 2019 08:22:05 +0000 (10:22 +0200)]
cellrenderertext: Don't unnecessarily ref a layout
We never pass a NULL layout to get_size().
Timm Bäder [Sun, 21 Jul 2019 08:02:30 +0000 (10:02 +0200)]
textlayout: Remove some outdated comments
These two members have been commented out for 19 years.
Timm Bäder [Sun, 21 Jul 2019 07:58:08 +0000 (09:58 +0200)]
entry: Measure icons again
This was previously removed because it changes the minimum and natural
size of the entry when the icons are shown/hidden at runtime. Just not
measuring them does not work however, so reintroduce this.
Timm Bäder [Sun, 21 Jul 2019 07:51:54 +0000 (09:51 +0200)]
placesview: Make "Other Locations" search case-insensitive
It's just weird to search for "c" and not find the list item labelled
"Computer".
Timm Bäder [Sun, 21 Jul 2019 07:47:09 +0000 (09:47 +0200)]
linedisplay: Save paragraph bg color inline
No need to allocate this separately.
Timm Bäder [Sun, 21 Jul 2019 07:13:24 +0000 (09:13 +0200)]
gtk.supp: Add a pixman_image_composite32 exception
Timm Bäder [Sun, 21 Jul 2019 07:07:27 +0000 (09:07 +0200)]
gtk.supp: add a FcDefaultSubstitute exception
Timm Bäder [Sun, 21 Jul 2019 07:06:50 +0000 (09:06 +0200)]
rendernodeparser: Fix a memory leak when parsing glyphs
Timm Bäder [Sun, 21 Jul 2019 07:06:29 +0000 (09:06 +0200)]
rendernodeparser: Fix a memory leak when parsing textures
Timm Bäder [Sun, 21 Jul 2019 07:06:10 +0000 (09:06 +0200)]
gl renderer: ops_set_modelview is (transfer full)
regarding the passed modelview matrix
Timm Bäder [Sat, 20 Jul 2019 11:04:26 +0000 (13:04 +0200)]
gl renderer: Pull out code from a loop
Does not not actually depend on anything done inside the loop.
Goran Vidović [Fri, 19 Jul 2019 21:29:56 +0000 (21:29 +0000)]
Update Croatian translation
Goran Vidović [Fri, 19 Jul 2019 21:20:13 +0000 (21:20 +0000)]
Update Croatian translation
Timm Bäder [Fri, 19 Jul 2019 14:42:56 +0000 (16:42 +0200)]
gl renderer: Replace a redundant function call
We're already getting the radius from the node above.
Timm Bäder [Fri, 19 Jul 2019 08:14:54 +0000 (10:14 +0200)]
filechooserwidget: Fold function into only caller
Timm Bäder [Fri, 19 Jul 2019 07:59:17 +0000 (09:59 +0200)]
filechooserwidget: Don't emit default-size-changed() in unroot()
It doesn't make much sense to assume the default size has changed just
because the widget has been unrooted.
Timm Bäder [Fri, 19 Jul 2019 07:55:11 +0000 (09:55 +0200)]
filechooser: Remove SETTINGS_KEY_WINDOW_POSITION
Now unused.
Timm Bäder [Fri, 19 Jul 2019 07:54:30 +0000 (09:54 +0200)]
filechooserwidget: Don't look at saved window position
We don't save it anymore so no need to look at it here.
Timm Bäder [Fri, 19 Jul 2019 07:54:14 +0000 (09:54 +0200)]
filechooserdialog: Stop using gtk_window_get_position()
Timm Bäder [Fri, 19 Jul 2019 07:47:16 +0000 (09:47 +0200)]
Revert "file chooser: Stop using gtk_window_get_position"
This reverts commit
2ed533c3e1f0fe776fb24cc370447a0c63e49f24.
This also made the filechooser dialog not save the window size anymore,
which does not depend on the gtk_window_get_position() removal.
Timm Bäder [Fri, 19 Jul 2019 07:36:25 +0000 (09:36 +0200)]
gtkfilechooserwidget: Temporarily disable revealer transitions...
... when going between recent and browse. It just looks weird to have
this transition while the treeview model is just cleared/repopulated
without any transition.
Timm Bäder [Fri, 19 Jul 2019 06:04:45 +0000 (08:04 +0200)]
placessidebar: Remove sidebar border again
Christoph Reiter [Thu, 18 Jul 2019 19:32:19 +0000 (19:32 +0000)]
Merge branch 'tests-no-box-packing' into 'master'
testsuite: Remove dangling references to box-packing tests
See merge request GNOME/gtk!997
Emmanuele Bassi [Thu, 18 Jul 2019 10:31:19 +0000 (10:31 +0000)]
Merge branch 'pc-libs-private' into 'master'
gtk4.pc: Move third-party libraries from Libs to Libs.private
See merge request GNOME/gtk!998
Emmanuele Bassi [Thu, 18 Jul 2019 10:11:12 +0000 (10:11 +0000)]
Merge branch 'gtk-4-support-tcrypt-with-proxy-handler' into 'master'
gtkmountoperation: Support TCRYPT options when using proxy handler
See merge request GNOME/gtk!245
segfault [Mon, 9 Jul 2018 19:13:50 +0000 (21:13 +0200)]
gtkmountoperation: Support TCRYPT options when using proxy handler
GMountOperation now supports options to unlock TCRYPT volumes. This
patch sets these options if they are returned by AskPassword() of a
GtkMountOperationHandlerProxy.
Simon McVittie [Wed, 17 Jul 2019 10:01:57 +0000 (11:01 +0100)]
testsuite: Remove dangling references to box-packing tests
These were removed in commit
c47abb5f, before 3.96.0.
Signed-off-by: Simon McVittie <smcv@debian.org>
Simon McVittie [Thu, 18 Jul 2019 08:20:57 +0000 (09:20 +0100)]
gtk4.pc: Move third-party libraries from Libs to Libs.private
This avoids "overlinking". These libraries are an implementation detail
of particular backends, so they only need to appear on library consumers'
linker command-lines if the dependency cannot be picked up from the
shared library automatically (when linking statically, or when building
on a deficient OS that doesn't support transitive dependencies between
shared libraries, in which case pkg-config should be built with
--enable-indirect-deps).
Signed-off-by: Simon McVittie <smcv@debian.org>
Timm Bäder [Mon, 15 Jul 2019 05:48:46 +0000 (07:48 +0200)]
scrollbar: Use a box layout
Makes a lot more sense than the intermediate box just for its layout.
Timm Bäder [Mon, 15 Jul 2019 04:56:19 +0000 (06:56 +0200)]
text: Don't leak emoji chooser
Timm Bäder [Mon, 15 Jul 2019 04:43:25 +0000 (06:43 +0200)]
menu: Fix an uninitialized value
If the menu does not have any children, we'd otherwise end up calling
g_object_ref() on an uninitialized value.
Timm Bäder [Mon, 15 Jul 2019 04:38:51 +0000 (06:38 +0200)]
progressbar: Use box layout
Instead of the custom layouting we did before.
Timm Bäder [Mon, 15 Jul 2019 03:38:25 +0000 (05:38 +0200)]
text: Move some locals into the closest scope
Timm Bäder [Mon, 15 Jul 2019 03:19:02 +0000 (05:19 +0200)]
text: Remove some useless casts
Timm Bäder [Mon, 15 Jul 2019 03:17:46 +0000 (05:17 +0200)]
text: Move some locals into the closest scope
Jordi Mas [Sun, 14 Jul 2019 09:25:12 +0000 (11:25 +0200)]
Update Catalan translation
Timm Bäder [Sat, 13 Jul 2019 16:49:08 +0000 (18:49 +0200)]
Remove some dead assignments
Timm Bäder [Sat, 13 Jul 2019 16:10:15 +0000 (18:10 +0200)]
Adwaita: Add fontbutton spacing back
Timm Bäder [Sat, 13 Jul 2019 16:08:45 +0000 (18:08 +0200)]
adwaita: Remove a dead rule
GtkFileChooserButtons are called "filechooserbutton" these days, not
button.file
Timm Bäder [Sat, 13 Jul 2019 15:35:59 +0000 (17:35 +0200)]
gl renderer: Fix opacity nodes with overlapping child nodes
Aurimas Černius [Sat, 13 Jul 2019 15:28:21 +0000 (18:28 +0300)]
Updated Lithuanian translation
Timm Bäder [Sat, 13 Jul 2019 15:06:22 +0000 (17:06 +0200)]
popover: Fix a broken cast
The widget passed here is priv->relative_to, not the popover.
Timm Bäder [Sat, 13 Jul 2019 09:12:47 +0000 (11:12 +0200)]
rendernodeparser: fix typo
Timm Bäder [Sat, 13 Jul 2019 08:10:17 +0000 (10:10 +0200)]
fishbowl: Plug a small leak
Timm Bäder [Sat, 13 Jul 2019 07:38:28 +0000 (09:38 +0200)]
picture: Unref previous paintable
We were leaking all of them.
Timm Bäder [Sat, 13 Jul 2019 07:38:14 +0000 (09:38 +0200)]
suppression file: Add glReadPixels mesa exception
Timm Bäder [Sat, 13 Jul 2019 07:37:47 +0000 (09:37 +0200)]
node editor: Manually unrealize all created renderers
This has not been a problem before since we were leaking them.
Timm Bäder [Fri, 12 Jul 2019 09:59:38 +0000 (09:59 +0000)]
Merge branch 'fix-issue-2014-gtk4' into 'master'
Fix a string leak in gtkemojicompletion.c [gtk4]
Closes #2014
See merge request GNOME/gtk!993
Luca Bacci [Fri, 12 Jul 2019 08:43:44 +0000 (08:43 +0000)]
Fix a string leak
Fixes #2014
Timm Bäder [Wed, 10 Jul 2019 06:26:00 +0000 (08:26 +0200)]
fpsoverlay: Fix fps overlay position
Matthias Clasen [Tue, 9 Jul 2019 19:39:58 +0000 (19:39 +0000)]
Merge branch 'wip/baedert/accelmap' into 'master'
AccelMap: Sort accels before iterating over them in foreach()
See merge request GNOME/gtk!980
Matthias Clasen [Tue, 9 Jul 2019 19:39:13 +0000 (19:39 +0000)]
Merge branch 'wip/baedert/for-master' into 'master'
Improve the valgrind experience
See merge request GNOME/gtk!984